Github user admackin commented on the issue:
https://github.com/apache/spark/pull/16652
Yes thatâs right, in MLUtils it supplies zero-labels as test cases (ie
assumes theyâre allowed, which for other regression algorithms would be
true). More than happy to patch that instead though if you think thatâs OK
â itâll just affect presumably a lot of other test cases.
Verifying the 0-labels cause exceptions isnât yet covered, but probably
should be (separately to MLUtils). (Iâll just need to find out how to assert
thrown errors in the Spark testing)
On 22 Jan 2017, 01:07 +1100, Sean Owen <notificati...@github.com>, wrote:
> I imagine there's a better way to do this without copying code. Do you
mean the common test code assumes 0 labels are permitted? then maybe it should
just not do that, because it's just using any old value to test.
> If it doesn't actually assume 0 labels are permitted, then its logic
should still work. It's just that this test would need some additional logic to
verify that 0 labels cause an exception.
> â
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub, or mute the thread.((
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
