Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16609#discussion_r97210324
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -172,6 +172,17 @@ class Dataset[T] private[sql](
this(sqlContext.sparkSession, logicalPlan, encoder)
}
+ /** A friendly name for this Dataset */
+ @Since("2.2.0")
--- End diff --
this doesn't seem like the convention for doc string. For example
```
/**
* Returns a Java list that contains randomly split Dataset with the
provided weights.
*
* @param weights weights for splits, will be normalized if they don't
sum to 1.
* @param seed Seed for sampling.
*
* @group typedrel
* @since 2.0.0
*/
```
it should have param, group, since.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
