Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/16594#discussion_r97216860
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -649,6 +649,14 @@ object SQLConf {
.doubleConf
.createWithDefault(0.05)
+ val SHOW_STATS_IN_EXPLAIN =
--- End diff --
I'm not sure. e.g., after joins of many tables, if `sizeInBytes` is
computed by the simple way (non-cbo way), we just multiply all the sizes of
these tables, then `sizeInBytes` becomes a ridiculously large value. I think
this will harm user experience.
I agree removing the flag can simplify code a lot, but I'm hesitated to
expose such information to all users.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
