Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/16579#discussion_r97249644
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -982,6 +982,33 @@ class SQLQuerySuite extends QueryTest with
SharedSQLContext {
spark.sessionState.conf.clear()
}
+ test("SPARK-19218 SET command should show a result in a sorted order") {
+ val overrideConfs = sql("SET").collect()
+ sql(s"SET test.key3=1")
+ sql(s"SET test.key2=2")
+ sql(s"SET test.key1=3")
+ val result = sql("SET").collect()
+ assert(result ===
+ (overrideConfs ++ Seq(
+ Row("test.key1", "3"),
+ Row("test.key2", "2"),
+ Row("test.key3", "1"))).sortBy(_.getString(0))
+ )
+ spark.sessionState.conf.clear()
+ }
+
+ test("SPARK-19218 `SET -v` should not fail with null value
configuration") {
+ import SQLConf._
+ val confEntry =
SQLConfigBuilder("spark.test").doc("doc").stringConf.createWithDefault(null)
+
+ try {
+ val result = sql("SET -v").collect()
+ assert(result === result.sortBy(_.getString(0)))
--- End diff --
Yes, but we need to clean up `spark.test` in order not to interrupt the
other test cases here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
