GitHub user HyukjinKwon opened a pull request:

    https://github.com/apache/spark/pull/16680

    [SPARK-16101][SQL] Refactoring CSV schema inference path to be consistent 
with JSON

    ## What changes were proposed in this pull request?
    
    This PR refactors CSV schema inference path to be consistent with JSON data 
source and moves some filtering codes having the similar/same logics into 
`CSVUtils`
    
     It makes the methods in classes have consistent arguments with JSON ones.
    
    `UnivocityParser` and `JacksonParser` 
        
    ``` scala
    private[csv] object CSVInferSchema {
      ...
        
      def infer(
          csv: Dataset[String],
          caseSensitive: Boolean,
          options: CSVOptions): StructType = {
      ...
    ```
        
    ``` scala
    private[sql] object InferSchema {
      ...
        
      def infer(
          json: RDD[String],
          columnNameOfCorruptRecord: String,
          configOptions: JSONOptions): StructType = {
      ...
    ```
    
    These allow schema inference from `Dataset[String]` directly. This 
completes refactoring CSV datasource and they are now pretty consistent.
    
    ## How was this patch tested?
    
    Existing tests should cover this.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/HyukjinKwon/spark SPARK-16101-schema-inference

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/16680.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #16680
    
----

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to