Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16582#discussion_r97610759
--- Diff: core/src/main/scala/org/apache/spark/ui/JettyUtils.scala ---
@@ -337,17 +350,20 @@ private[spark] object JettyUtils extends Logging {
// The number of selectors always equals to the number of acceptors
minThreads += connector.getAcceptors * 2
}
- server.setConnectors(connectors.toArray)
pool.setMaxThreads(math.max(pool.getMaxThreads, minThreads))
val errorHandler = new ErrorHandler()
errorHandler.setShowStacks(true)
errorHandler.setServer(server)
server.addBean(errorHandler)
+
+ gzipHandlers.foreach(collection.addHandler)
server.setHandler(collection)
+
+ server.setConnectors(connectors.toArray)
--- End diff --
Mostly for grouping. "This is where all handlers are added to the server."
In any case I have another change (#16625) that kinda moves all this stuff
around anyway...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
