Github user chouqin commented on the pull request:
https://github.com/apache/spark/pull/2332#issuecomment-55122746
@jkbradley thanks for your replies. as I replied in your comments, I have
changed `minInstancePerNode` to 2 in test cases, and add one more test case to
test that when a split doesn't satisfy min instances per node requirements,
this split will not be chosen, even though the info gain is large(in this test
case, total number of instances is 4, and we can find a split to let both left
and right child have 2 instances). Do you think this is OK?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
