Github user jinxing64 commented on the issue:

    https://github.com/apache/spark/pull/16620
  
    >hmm, this is a nuisance. I don't see any good way to get rid of this sleep 
... but now that I think about it, why can't you do this in DAGSchedulerSuite? 
it seems like this can be entirely contained to the DAGScheduler and doesn't 
require tricky interactions with other parts of the scheduler. (I'm sorry I 
pointed you in the wrong direction earlier -- I thought perhaps you had tried 
to copy the examples of DAGSchedlerSuite but there was some reason you 
couldn't.)
    
    `DAGSchedulerSuite` is quite hard for me. Because this bug happens during 
the interreaction between `DAGScheduler` and `TaksSchedulerImpl`, actually the 
conflicting exception is thrown in `TaskSchedulerImpl` when `submitTasks` is 
called from `DAGScheduler`. `DAGSchedulerSuite` only provides a very simple 
`TaskScheduler`, of course I can check the conflicting in it but I don't think 
it is convincing enough.
    
    I don't like the `Thread.sleep(5000)` either. But I didn't find a better 
way. I'm sorry to add `TestDAGScheduler` in `SchedulerIntegrationSuite` just 
like `TestTaskScheduler` for tracking more state. But perhaps it can also be 
used in the future. If it is not preferred, I'm so sorry.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to