Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16614#discussion_r97768039
  
    --- Diff: 
core/src/test/scala/org/apache/spark/deploy/history/FsHistoryProviderSuite.scala
 ---
    @@ -47,7 +47,7 @@ class FsHistoryProviderSuite extends SparkFunSuite with 
BeforeAndAfter with Matc
       private var testDir: File = null
     
       before {
    -    testDir = Utils.createTempDir()
    +    testDir = Utils.createTempDir(namePrefix = s"a b%20c+d")
    --- End diff --
    
    Hm, because this affects the whole suite, I wonder if it's more sensible to 
test this behavior once in a specific test case, rather than test the behavior 
everywhere. It works, and I don't have a big problem with it, just looks a 
little surprising to read.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to