Github user brkyvz commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16213#discussion_r97841000
  
    --- Diff: 
external/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisCheckpointer.scala
 ---
    @@ -64,7 +64,18 @@ private[kinesis] class KinesisCheckpointer(
       def removeCheckpointer(shardId: String, checkpointer: 
IRecordProcessorCheckpointer): Unit = {
         synchronized {
           checkpointers.remove(shardId)
    -      checkpoint(shardId, checkpointer)
    +    }
    +    try {
    +      // We must call `checkpoint()` with no parameter to finish reading 
shards.
    +      // See an URL below for details:
    +      // https://forums.aws.amazon.com/thread.jspa?threadID=244218
    +      KinesisRecordProcessor.retryRandom(checkpointer.checkpoint(), 4, 100)
    --- End diff --
    
    Can you run this if `checkpointer != null`. The docs mention that the 
`checkpointer` may be null.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to