Github user holdenk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16533#discussion_r97911192
  
    --- Diff: python/pyspark/sql/functions.py ---
    @@ -1847,8 +1848,7 @@ def __call__(self, *cols):
             return Column(jc)
     
     
    -@since(1.3)
    -def udf(f, returnType=StringType()):
    +def _udf(f, returnType=StringType()):
         """Creates a :class:`Column` expression representing a user defined 
function (UDF).
     
         .. note:: The user-defined functions must be deterministic. Due to 
optimization,
    --- End diff --
    
    Even though we've got this with an _ maybe through in the docstring its for 
internal use only? Also since this is for internal use only maybe most of this 
should be moved to the public udf function now instead of on the internal only 
method?
    
    Unless we intend for users to call `_udf` in which case we need to give it 
a different name.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to