Github user nchammas commented on a diff in the pull request:
https://github.com/apache/spark/pull/2339#discussion_r17378523
--- Diff: ec2/spark_ec2.py ---
@@ -60,9 +60,11 @@ def parse_args():
parser.add_option(
"-s", "--slaves", type="int", default=1,
help="Number of slaves to launch (default: %default)")
- parser.add_option(
- "-w", "--wait", type="int", default=120,
- help="Seconds to wait for nodes to start (default: %default)")
+ # NOTE: For strict "API" compatibility, we should probably leave this
in
+ # and just mark it as deprecated / not used.
+ # parser.add_option(
+ # "-w", "--wait", type="int", default=120,
+ # help="Seconds to wait for nodes to start (default: %default)")
--- End diff --
I considered that, but I wonder if it would actually be useful to do that.
If the cluster is taking a while to launch, putting the hard stop will just get
in the user's way. They'll have to relaunch with `--resume` anyway, right? I
think it might be more straightforward to deprecate the option completely and
just let users `Ctrl + C` if they feel the launch is taking too long or if they
know something else is wrong. What do you say?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
