Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16700#discussion_r98133500
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -899,6 +918,22 @@ private[spark] class HiveExternalCatalog(conf:
SparkConf, hadoopConf: Configurat
spec, partitionColumnNames, tablePath)
try {
tablePath.getFileSystem(hadoopConf).rename(wrongPath, rightPath)
+
+ // If the newSpec contains more than one depth partition,
FileSystem.rename just deletes
+ // the leaf(i.e. wrongPath), we should check if wrongPath's
parents need to be deleted.
+ // for example:
+ // newSpec is 'A=1/B=2', after renamePartitions by Hive, the
location path in FileSystem
+ // is changed to 'a=1/b=2', which is wrongPath, then we renamed
to 'A=1/B=2', and
+ // 'a=1/b=2' in FileSystem is deleted, while 'a=1' is already
exists,
+ // which should also be deleted
+ val delHivePartPathAfterRename = getExtraPartPathCreatedByHive(
+ lowerCasePartitionSpec(spec),
--- End diff --
The last comment: I prefer to calling `lowerCasePartitionSpec ` in the func
`getExtraPartPathCreatedByHive`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
