GitHub user lw-lin opened a pull request:
https://github.com/apache/spark/pull/16719
[SPARK-19385][SQL] During canonicalization, `NOT(l, r)` should not expect
such cases that l.hashcode > r.hashcode
## What changes were proposed in this pull request?
During canonicalization, `NOT(l, r)` should not expect such cases that
`l.hashcode > r.hashcode`.
Take the rule `case NOT(Greater(l, r)) if l.hashcode > r.hashcode` for
example, it should never be matched since `Greater(l, r)` itself would be
re-written as `Greater(r, l)` after canonicalization given `l.hashcode >
r.hashcode`.
## How was this patch tested?
This patch expanded the `NOT` test case.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lw-lin/spark canonicalize
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/16719.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #16719
----
commit da0b98c7b255819ca7c24d32209ff5803ce46eab
Author: Liwei Lin <[email protected]>
Date: 2017-01-22T09:05:39Z
Fix
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
