Github user imatiach-msft commented on the issue:
https://github.com/apache/spark/pull/16699
@actuaryzhang thank you for updating the PR - I agree with your first two
points. With regards to the method of RDD[Instance] also working with
RDD[OffsetInstance], I think it should work, as long as you define the method
such that it takes in the parameter myAwesomeMethod(myRdd: RDD[_ <: Instance])
I think you need that "<:" in the method definition to allow the method to
take in anything that inherits from Instance.
With regards to "Would you please elaborate on the following comment..." it
looks like I made a mistake, I did not notice that you were subtracting the
offset from the response when creating the Instance object in the previous
commit, in which case you can ignore that comment.
The PR looks good to me, maybe the committers can comment on it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
