Github user lw-lin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16719#discussion_r98322886
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionSetSuite.scala
---
@@ -75,10 +107,14 @@ class ExpressionSetSuite extends SparkFunSuite {
setTest(1, aUpper >= bUpper, bUpper <= aUpper)
// `Not` canonicalization
- setTest(1, Not(aUpper > 1), aUpper <= 1, Not(Literal(1) < aUpper),
Literal(1) >= aUpper)
- setTest(1, Not(aUpper < 1), aUpper >= 1, Not(Literal(1) > aUpper),
Literal(1) <= aUpper)
- setTest(1, Not(aUpper >= 1), aUpper < 1, Not(Literal(1) <= aUpper),
Literal(1) > aUpper)
- setTest(1, Not(aUpper <= 1), aUpper > 1, Not(Literal(1) >= aUpper),
Literal(1) < aUpper)
+ setTest(1, Not(maxHash > 1), maxHash <= 1, Not(Literal(1) < maxHash),
Literal(1) >= maxHash)
+ setTest(1, Not(minHash > 1), minHash <= 1, Not(Literal(1) < minHash),
Literal(1) >= minHash)
+ setTest(1, Not(maxHash < 1), maxHash >= 1, Not(Literal(1) > maxHash),
Literal(1) <= maxHash)
+ setTest(1, Not(minHash < 1), minHash >= 1, Not(Literal(1) > minHash),
Literal(1) <= minHash)
+ setTest(1, Not(maxHash >= 1), maxHash < 1, Not(Literal(1) <= maxHash),
Literal(1) > maxHash)
+ setTest(1, Not(minHash >= 1), minHash < 1, Not(Literal(1) <= minHash),
Literal(1) > minHash)
+ setTest(1, Not(maxHash <= 1), maxHash > 1, Not(Literal(1) >= maxHash),
Literal(1) < maxHash)
+ setTest(1, Not(minHash <= 1), minHash > 1, Not(Literal(1) >= minHash),
Literal(1) < minHash)
--- End diff --
yea sure they are covered correctly even prior to this patch's changes!
the previous `aUpper`'hashcode is either greater than or less than `1`'s
hashcode but can not be both, while this change aims to test both cases -- but
I'm quite open to revert the changes if they are considered unnecessary.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
