Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16700#discussion_r98327523
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -899,6 +919,21 @@ private[spark] class HiveExternalCatalog(conf:
SparkConf, hadoopConf: Configurat
spec, partitionColumnNames, tablePath)
try {
tablePath.getFileSystem(hadoopConf).rename(wrongPath, rightPath)
--- End diff --
Found an issue here... When we call `rename`, not all the file systems have
the same behaviors. For example, on mac OS, when we doing this
`.../tbl/a=5/b=6` -> `.../tbl/A=5/B=6` . The result is `.../tbl/a=5/B=6`. Thus,
it is not recursive. However, the file system used in Jenkin does not have such
an issue. You can hit this issue if you are using macOS. Thus, this fix causes
an regression, but the bug is not in your fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
