Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16723#discussion_r98329844
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/ml/classification/LinearSVC.scala ---
    @@ -47,7 +47,7 @@ private[classification] trait LinearSVCParams extends 
ClassifierParams with HasR
     /**
      * :: Experimental ::
      *
    - * Linear SVM Classifier 
(https://en.wikipedia.org/wiki/Support_vector_machine#Linear_SVM)
    + * [[https://en.wikipedia.org/wiki/Support_vector_machine#Linear_SVM  
Linear SVM Classifier]]
    --- End diff --
    
    Would you mind changing it to
    
    ```
     * <a 
href="https://en.wikipedia.org/wiki/Support_vector_machine#Linear_SVM";>
     * Linear SVM Classifier</a>
    ```
    
    ? It seems scala link annotation breaks Javadoc8 as below:
    
    ```
    [error] 
.../spark/mllib/target/java/org/apache/spark/ml/classification/LinearSVC.java:5:
 error: unexpected text
    [error]  * {@link 
https://en.wikipedia.org/wiki/Support_vector_machine#Linear_SVM  Linear SVM 
Classifier}
    ```
    
    I tested this via `./build/sbt unidoc` with Java 8.
    
    (Currently, it seems there are already few errors. Let me fix them with 
other warnings in near future).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to