Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16736#discussion_r98522244
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/internal/SQLConfSuite.scala ---
@@ -221,6 +221,19 @@ class SQLConfSuite extends QueryTest with
SharedSQLContext {
.sessionState.conf.warehousePath.stripSuffix("/"))
}
+ test("DATA_SOURCE_TABLE_RELATION_CACHE_MAX_SIZE") {
+
assert(spark.conf.get(SQLConf.DATA_SOURCE_TABLE_RELATION_CACHE_MAX_SIZE) ===
1000)
+ withSQLConf(SQLConf.DATA_SOURCE_TABLE_RELATION_CACHE_MAX_SIZE.key ->
"2000") {
+
assert(spark.conf.get(SQLConf.DATA_SOURCE_TABLE_RELATION_CACHE_MAX_SIZE) ===
2000)
+ }
--- End diff --
We can change the value at the runtime, but the changed value does not
affect the actual cache size.
I am thinking if we should move the conf to `StaticSQLConf`, unless we
really need to allow users to change it at runtime.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
