Github user actuaryzhang commented on the issue:

    https://github.com/apache/spark/pull/16740
  
    @sethah Thanks for your review. Yes, using `foldLeft` would be the simplest 
fix. I have included both your suggested changes in the new commit. 
    
    Yes, we could handle the special case of the intercept only model outside 
IWLS. But I think it would be better to use the current fix: a) it allows IWLS 
to handle edge case, b) the fix is general and less likely to be affected by 
future structure changes of GLM (e.g., allowing offset). Does this make sense?  
 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to