Github user squito commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16620#discussion_r98699067
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala 
---
    @@ -1212,8 +1223,9 @@ class DAGScheduler(
     
                   clearCacheLocs()
     
    -              if (!shuffleStage.isAvailable) {
    -                // Some tasks had failed; let's resubmit this shuffleStage
    +              if (!shuffleStage.isAvailable && noActiveTaskSetManager) {
    --- End diff --
    
    You need to update this for mapStageJobs -- the `else` branch will now run 
if the shuffleStage is not available, but there is an active task set manager, 
which we don't want.  Also calling `submitWaitingChildStages(shuffleStage)` is 
confusing (though it seems to be correct).
    
    (or use the other version I suggested)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to