Github user zsxwing commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16686#discussion_r98756883
  
    --- Diff: 
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaOffsetReader.scala
 ---
    @@ -108,7 +113,14 @@ private[kafka010] class KafkaOffsetReaderImpl(
     
       def close(): Unit = consumer.close()
     
    -  def fetchSpecificStartingOffsets(
    +  override def fetchTopicPartitions(): Set[TopicPartition] = {
    +    assert(Thread.currentThread().isInstanceOf[UninterruptibleThread])
    +    // Poll to get the latest assigned partitions
    +    consumer.poll(0)
    +    consumer.assignment().asScala.toSet
    --- End diff --
    
    nit: please also call `pause` like this to avoid fetching the real data 
when reusing the relation.
    ```
    val partitions = consumer.assignment()
    consumer.pause(partitions)
    partitions.asScala.toSet
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to