Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/16722#discussion_r98778763
--- Diff:
mllib-local/src/test/scala/org/apache/spark/ml/util/TestingUtils.scala ---
@@ -48,7 +48,7 @@ object TestingUtils {
/**
* Private helper function for comparing two values using absolute
tolerance.
*/
- private def AbsoluteErrorComparison(x: Double, y: Double, eps: Double):
Boolean = {
+ private[ml] def AbsoluteErrorComparison(x: Double, y: Double, eps:
Double): Boolean = {
--- End diff --
It's not used. I just changed the scope of both methods, I can change it
back of course. I don't see a great reason to make this public since most users
will use `relTol` instead. I'm open to other opinions though.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
