Github user holdenk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12135#discussion_r98793496
  
    --- Diff: python/pyspark/sql/dataframe.py ---
    @@ -1365,18 +1364,41 @@ def approxQuantile(self, col, probabilities, 
relativeError):
             Space-efficient Online Computation of Quantile Summaries]]
             by Greenwald and Khanna.
     
    -        :param col: the name of the numerical column
    +        Note that rows containing any null values will be removed before 
calculation.
    +
    +        :param col: str, list.
    +          Can be a single column name, or a list of names for multiple 
columns.
             :param probabilities: a list of quantile probabilities
               Each number must belong to [0, 1].
               For example 0 is the minimum, 0.5 is the median, 1 is the 
maximum.
             :param relativeError:  The relative target precision to achieve
               (>= 0). If set to zero, the exact quantiles are computed, which
               could be very expensive. Note that values greater than 1 are
               accepted but give the same result as 1.
    -        :return:  the approximate quantiles at the given probabilities
    +        :return:  the approximate quantiles at the given probabilities. If
    +          the input `col` is a string, the output is a list of float. If 
the
    +          input `col` is a list or tuple of strings, the output is also a
    +          list, but each element in it is a list of float, i.e., the output
    +          is a list of list of float.
    --- End diff --
    
    Also float -> floats here


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to