Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16750#discussion_r98834088
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVOptions.scala
---
@@ -161,12 +163,3 @@ private[csv] class CSVOptions(@transient private val
parameters: CaseInsensitive
settings
}
}
-
-object CSVOptions {
--- End diff --
The `CSVOptions` (and also `JSONOptions`) will always have to take
`timeZone` option.
I don't want callers to forget to specify it by these convenient methods.
Or should I add the default timezone id to these methods?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
