Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16762#discussion_r98834480
  
    --- Diff: sql/core/src/test/resources/sql-tests/inputs/cross-join.sql ---
    @@ -33,3 +33,5 @@ create temporary view D(d, vd) as select * from nt1;
     -- Allowed since cross join with C is explicit
     select * from ((A join B on (a = b)) cross join C) join D on (a = d);
     
    +-- Cross joins with non-equal predicates
    +SELECT * FROM nt1 CROSS JOIN nt2 ON (nt1.k > nt2.k);
    --- End diff --
    
    So far, the SQL syntax allows users to specify the join condition. 
    
    The Dataset API does not allow users to do it, but users still can do it by 
using the filter, which will be pushed into the cross join.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to