Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/12135#discussion_r99072952
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameStatFunctions.scala ---
@@ -75,13 +76,43 @@ final class DataFrameStatFunctions private[sql](df:
DataFrame) {
}
/**
+ * Calculates the approximate quantiles of numerical columns of a
DataFrame.
+ * @see [[DataFrameStatsFunctions.approxQuantile(col:Str*
approxQuantile]] for
+ * detailed description.
+ *
+ * Note that rows containing any null or NaN values values will be
removed before
+ * calculation.
+ * @param cols the names of the numerical columns
+ * @param probabilities a list of quantile probabilities
+ * Each number must belong to [0, 1].
+ * For example 0 is the minimum, 0.5 is the median, 1 is the maximum.
+ * @param relativeError The relative target precision to achieve (>= 0).
--- End diff --
Ah yes, sorry the comments imply building it separately from the main
jenkins build, but if we want to avoid breaking Java 8 unidoc I was thinking
building it as part of the normal PR build process would be better. Regardless
lets move discussion over to that JIRA :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
