Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/16686#discussion_r99200075
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSourceProvider.scala
---
@@ -251,7 +315,43 @@ private[kafka010] class KafkaSourceProvider extends
StreamSourceProvider
}
}
- override def shortName(): String = "kafka"
+ private def validateStream(caseInsensitiveParams: Map[String, String]) =
{
+ caseInsensitiveParams.get(ENDING_OFFSETS_OPTION_KEY).map(_ =>
+ throw new IllegalArgumentException("ending offset not valid in
stream mode"))
--- End diff --
nit: lets be consistent with the error message style. use "streaming
queries" and "batch queries". instead of "stream mode"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
