Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/16733#discussion_r99255011 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/jdbc/OracleDialect.scala --- @@ -29,7 +29,12 @@ private case object OracleDialect extends JdbcDialect { override def getCatalystType( --- End diff -- Aha, I see. you're right and it seems `JdbcUtils` always sets `scale` https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala#L285. However, since I got some reports (https://www.mail-archive.com/user@spark.apache.org/msg61280.html) from spark-users, I made this pr. I feel some weird and I keep looking into this. I appreciate your suggestions.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org