Github user imatiach-msft commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16722#discussion_r99275700
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/mllib/tree/impurity/Impurity.scala ---
    @@ -79,7 +79,12 @@ private[spark] abstract class ImpurityAggregator(val 
statsSize: Int) extends Ser
        * @param allStats  Flat stats array, with stats for this (node, 
feature, bin) contiguous.
        * @param offset    Start index of stats for this (node, feature, bin).
        */
    -  def update(allStats: Array[Double], offset: Int, label: Double, 
instanceWeight: Double): Unit
    +  def update(
    +      allStats: Array[Double],
    +      offset: Int,
    +      label: Double,
    +      numSamples: Int,
    +      sampleWeight: Double): Unit
    --- End diff --
    
    should the numSamples/sampleWeight be added to the doc here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to