Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/16686#discussion_r99329545
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaOffsets.scala
---
@@ -19,14 +19,31 @@ package org.apache.spark.sql.kafka010
import org.apache.kafka.common.TopicPartition
-/*
- * Values that can be specified for config startingOffsets
+/**
+ * Values that can be specified to configure starting,
+ * ending, and specific offsets.
*/
-private[kafka010] sealed trait StartingOffsets
+private[kafka010] sealed trait KafkaOffsets
--- End diff --
The more I think, I feel that its weird to name this generic
"KafkaOffsets". Let's brainstorm on this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
