Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/15505#discussion_r99458651
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskDescription.scala ---
@@ -66,7 +100,8 @@ private[spark] object TaskDescription {
}
}
- def encode(taskDescription: TaskDescription): ByteBuffer = {
+ @throws[TaskNotSerializableException]
+ def encode(taskDescription: TaskDescription, serializedTask:
ByteBuffer): ByteBuffer = {
--- End diff --
Why do you find it more readable to pass in the serializedTask? I'd prefer
removing serializedTask, since serializedTask is created as part of serializing
the taskDescription, which is the functionality that this method is supposed to
be doing. It's confusing to have this encode() method just doing part of the
serialization, and expecting the caller to do the other part.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
