Github user zero323 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16792#discussion_r99470996
  
    --- Diff: python/pyspark/sql/dataframe.py ---
    @@ -1272,16 +1272,18 @@ def replace(self, to_replace, value, subset=None):
             """Returns a new :class:`DataFrame` replacing a value with another 
value.
             :func:`DataFrame.replace` and :func:`DataFrameNaFunctions.replace` 
are
             aliases of each other.
    +        Values `to_replace` and `value` should be homogeneous. Mixed 
string and numeric
    --- End diff --
    
    I've seen some variation between bundled Py4j (`py4j-0.10.4-src.zip`) and 
pip installed version (should be the same `py4j==0.10.4`) which suggests there 
is something more going on here but I would really avoid restricting Python 
users even more. 
    
    If necessary we can always proactively cast all `ints` to `floats`. It will 
be an ugly hack but won't affect user code or correctness.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to