Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16497#discussion_r99494220
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/aggregate/PercentileSuite.scala
---
@@ -119,35 +174,73 @@ class PercentileSuite extends SparkFunSuite {
test("call from sql query") {
--- End diff --
Can you remove this entire test. We don't have to check the `sql` method.
This feels like over testing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
