Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16664#discussion_r99520045
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala
---
@@ -893,6 +896,12 @@ object SparkSession {
}
}
+ private def createQueryExecutionListeners(conf: SparkConf):
Seq[QueryExecutionListener] = {
+ conf.get(StaticSQLConf.QUERY_EXECUTION_LISTENERS)
+ .map(Utils.classForName(_))
+ .map(_.newInstance().asInstanceOf[QueryExecutionListener])
--- End diff --
Simply throwing `ClassNotFoundException` might not be good to end users, if
we plan to make this SQL configuration external.
Could you use the try and catch to issue a better error message when we are
unable to create/initialize the class? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
