Github user sarutak commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16625#discussion_r99540244
  
    --- Diff: docs/security.md ---
    @@ -49,10 +49,6 @@ component-specific configuration namespaces used to 
override the default setting
         <th>Component</th>
       </tr>
       <tr>
    -    <td><code>spark.ssl.fs</code></td>
    --- End diff --
    
    The namespace `fs` seems to be still referred 
(https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/SecurityManager.scala#L259
 ).
    We shouldn't remove this description should we?
    
    Also it's chance to modify the description about the namespace in 
`SecurityManager.scala`.
    
    ```
     *  All the SSL settings like `spark.ssl.xxx` where `xxx` is a particular 
configuration property,
     *  denote the global configuration for all the supported protocols. In 
order to override the global
     *  configuration for the particular protocol, the properties must be 
overwritten in the
     *  protocol-specific namespace. Use `spark.ssl.yyy.xxx` settings to 
overwrite the global
     *  configuration for particular protocol denoted by `yyy`. Currently `yyy` 
can be only`fs` for
     *  broadcast and file server.
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to