Github user tgravescs commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2350#discussion_r17427470
  
    --- Diff: 
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/YarnSparkHadoopUtil.scala
 ---
    @@ -142,14 +136,13 @@ object YarnSparkHadoopUtil {
               m.appendReplacement(sb, Matcher.quoteReplacement(replace))
             }
             m.appendTail(sb)
    -        addToEnvironment(env, parts(0), sb.toString(), classPathSeparator)
    --- End diff --
    
    why was this changed? It is no longer appending if specified twice just 
overriding? 
    
    I'll admin appending isn't necessarily what you want to do in some cases 
but in some it is.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to