Github user sethah commented on the issue:
https://github.com/apache/spark/pull/16740
Regarding the tests - I don't think the tests should change _depending on_
the implementation. I don't think it's valid to say that we don't need to test
this thoroughly because we know that it's just calling IRLS under the hood -
especially since someone in the future might come along and change it to, say
an analytical approach. Then maybe the non-rigorous tests still pass even
though the implementation is wrong. And since we are already aware of a
reasonable situation where some families will pass and some will not, I think
it's a good idea to test them all. Sorry, not trying to be a pain :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
