Github user kayousterhout commented on a diff in the pull request: https://github.com/apache/spark/pull/16813#discussion_r99712707 --- Diff: core/src/test/scala/org/apache/spark/scheduler/PoolSuite.scala --- @@ -28,19 +29,19 @@ import org.apache.spark.scheduler.SchedulingMode._ */ class PoolSuite extends SparkFunSuite with LocalSparkContext { - val LOCAL = "local" - val APP_NAME = "PoolSuite" - val SCHEDULER_ALLOCATION_FILE_PROPERTY = "spark.scheduler.allocation.file" + private val LOCAL = "local" --- End diff -- In general we don't make test variables private because they're not exposed publicly anyway, so I'd revert this.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org