Github user tgravescs commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2350#discussion_r17431569
  
    --- Diff: 
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/YarnSparkHadoopUtil.scala
 ---
    @@ -142,14 +136,13 @@ object YarnSparkHadoopUtil {
               m.appendReplacement(sb, Matcher.quoteReplacement(replace))
             }
             m.appendTail(sb)
    -        addToEnvironment(env, parts(0), sb.toString(), classPathSeparator)
    --- End diff --
    
    Yep, I understand it isn't what we want for all variables, but changing it 
breaks backwards compatibility.  It also makes it impossible to do the 
appending so we are losing functionality. This code was originally a copy of 
MapReduce and it has the same broken behavior.  We should find a way for it to 
handle both cases, but that is a separate jira.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to