Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/16795#discussion_r99806592
--- Diff: sql/core/pom.xml ---
@@ -130,6 +130,12 @@
<scope>test</scope>
</dependency>
<dependency>
+ <groupId>org.apache.avro</groupId>
+ <artifactId>avro</artifactId>
+ <version>1.8.0</version>
--- End diff --
Two questions still -- should this not just use the same version of Avro as
the rest of the project? `avro.version` is already defined to be 1.7.7 in the
parent POM. I'd think we need to use that instead.
Second, is this really just a test issue? `sql/hive` depends on `avro`. It
may be that really `sql/core` needs to depend on `avro` too -- in non-test
scope. In fact, `mvn dependency:tree` shows that `sql/core` already depends on
it in `compile` scope transitively.
Therefore, I wonder if it is best to simply remove the `version` and
`scope` here. That may be the most correct thing?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
