GitHub user CodingCat opened a pull request:
https://github.com/apache/spark/pull/16840
[SPARK-19499][SS]Add more notes in the comments of Sink.addBatch()
## What changes were proposed in this pull request?
addBatch method in Sink trait is supposed to be a synchronous method to
coordinate with the fault-tolerance design in StreamingExecution (being
different with the compute() method in DStream)
We need to add more notes in the method of this method to remind the
developers
## How was this patch tested?
existing tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/CodingCat/spark SPARK-19499
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/16840.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #16840
----
commit 24bfa382a43c2fbbf54b24bb8f03766910216490
Author: CodingCat <[email protected]>
Date: 2016-03-07T14:37:37Z
improve the doc for "spark.memory.offHeap.size"
commit 2209e345df4636f8fa881b3ad45084b75f9fe3eb
Author: CodingCat <[email protected]>
Date: 2016-03-07T19:00:16Z
fix
commit f2d9db1b725c6dcadee5ee1a7e43d5fbb601f367
Author: CodingCat <[email protected]>
Date: 2016-12-28T03:52:41Z
Merge branch 'master' of https://github.com/apache/spark
commit dd409b4c7a5afe07cfe6b36691bed42049a5c7b2
Author: CodingCat <[email protected]>
Date: 2017-01-13T04:10:40Z
Merge branch 'master' of https://github.com/apache/spark
commit f026adebb787a09dc4cc90f87dc94590ab1816f7
Author: CodingCat <[email protected]>
Date: 2017-01-25T03:53:56Z
Merge branch 'master' of https://github.com/apache/spark
commit 535b60eb19b272fe3f4b421be16945bf92e60343
Author: CodingCat <[email protected]>
Date: 2017-02-07T16:37:05Z
Merge branch 'master' of https://github.com/apache/spark
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
