Github user budde commented on a diff in the pull request:
https://github.com/apache/spark/pull/16744#discussion_r99907831
--- Diff:
external/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisUtils.scala
---
@@ -449,22 +935,48 @@ private class KinesisUtilsPythonHelper {
checkpointInterval: Duration,
storageLevel: StorageLevel,
awsAccessKeyId: String,
- awsSecretKey: String
- ): JavaReceiverInputDStream[Array[Byte]] = {
+ awsSecretKey: String,
+ stsAssumeRoleArn: String,
+ stsSessionName: String,
+ stsExternalId: String): JavaReceiverInputDStream[Array[Byte]] = {
+ // scalastyle:on
+ if (!(stsAssumeRoleArn != null && stsSessionName != null &&
stsExternalId != null)
+ && !(stsAssumeRoleArn == null && stsSessionName == null &&
stsExternalId == null)) {
+ throw new IllegalArgumentException("stsAssumeRoleArn,
stsSessionName, and stsExtenalId " +
--- End diff --
See previous comment in KinesisUtils. Obviously it's easier to deal with
optional arguments for the Python API but I'd favor keeping this consistent
with the definitions of ```createStream()``` for Java/Scala
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
