Github user kayousterhout commented on the issue:

    https://github.com/apache/spark/pull/15505
  
    Thanks for adding the unit test but it doesn't quite cover the case Imran 
brought up: can you write a test for when the LaunchTasks call includes tasks 
from multiple task sets, one with tasks that should fail (because they're not 
serializable) and one with tasks that should successfully be serialized and 
launched? (and I'm concerned a bug still exists around this case) One way to do 
this is to directly instantiate a CoarseGrainedSchedulerBackend and pass in a 
mocked TaskSchedulerImpl.  Then you can call RegisterExecutor to register an 
executor, and then call ReviveOffers (and have your mocked TaskSchedulerImpl 
return tasks for two different task sets).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to