Github user dhunziker commented on a diff in the pull request:
https://github.com/apache/spark/pull/16812#discussion_r99953321
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVInferSchemaSuite.scala
---
@@ -73,6 +73,12 @@ class CSVInferSchemaSuite extends SparkFunSuite {
assert(CSVInferSchema.inferField(LongType, "2015-08 14:49:00",
options) == StringType)
}
+ test("Boolean field types are inferred correctly from custom value") {
+ val options = new CSVOptions(Map("trueValue" -> "yes"))
+ assert(CSVInferSchema.inferField(BooleanType, "yES", options) ==
BooleanType)
--- End diff --
No assert in this suite uses `===`. Should I make this consistent and
replace all occurrences of `==` in that suite with `===` or just the one in the
lines I've changed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
