Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/16740#discussion_r99977340
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -335,6 +335,9 @@ class GeneralizedLinearRegression @Since("2.0.0")
(@Since("2.0.0") override val
throw new SparkException(msg)
}
+ require(numFeatures > 0 || $(fitIntercept),
+ "Specified model is empty with neither intercept nor feature.")
--- End diff --
The message is a bit cryptic. How about "GeneralizedLinearRegression was
given data with 0 features, and with Param fitIntercept set to false. To fit a
model with 0 features, fitIntercept must be set to true."
Other than this, your PR looks good to me. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
