Github user lw-lin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16736#discussion_r100003797
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/internal/SQLConfEntrySuite.scala
---
@@ -164,6 +164,18 @@ class SQLConfEntrySuite extends SparkFunSuite {
assert(conf.getConf(confEntry) === Some("a"))
}
+ test("checkValue()") {
--- End diff --
thanks.
`FILESOURCE_TABLE_RELATION_CACHE_SIZE` now is a static conf, so we can not
change it's value in tests, so we might not be able to test
`FILESOURCE_TABLE_RELATION_CACHE_SIZE` specifically? If so, should we remove
this test or keep it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
