Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16864#discussion_r100261151
--- Diff:
common/sketch/src/main/java/org/apache/spark/util/sketch/BloomFilter.java ---
@@ -148,6 +153,20 @@ int getVersionNumber() {
public abstract boolean mightContainBinary(byte[] item);
/**
+ * Returns a new Bloom filter of the union of two Bloom filters.
+ * Unlike mergeInplace, this will not cause a mutation.
+ * Callers must ensure the bloom filters are appropriately sized to
avoid saturating them.
+ *
+ * @throws IncompatibleUnionException if either are null, different
classes, or different size or number of hash functions
+ */
+ public abstract BloomFilterImpl createUnionBloomFilter(BloomFilter
other) throws IncompatibleUnionException;
--- End diff --
how about just calling this union?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
