Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16871#discussion_r100284371
  
    --- Diff: build/mvn ---
    @@ -22,7 +22,7 @@ _DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
     # Preserve the calling directory
     _CALLING_DIR="$(pwd)"
     # Options used during compilation
    -_COMPILE_JVM_OPTS="-Xmx2g -XX:MaxPermSize=512M 
-XX:ReservedCodeCacheSize=512m"
    --- End diff --
    
    It's still in Java 8. I actually removed this because I think it's defunct 
and no longer needed, but I admit it's not strictly related to Java 8. I'd put 
it back if anyone has doubts, but if nobody can recall what it's for (I've 
never set it in dev or production) maybe it's removable now


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to