Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r100332529
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala
---
@@ -298,22 +312,22 @@ class JacksonParser(
// Here, we pass empty `PartialFunction` so that this case can be
// handled as a failed conversion. It will throw an exception as
// long as the value is not null.
- parseJsonToken(parser, dataType)(PartialFunction.empty[JsonToken,
Any])
+ parseJsonToken[AnyRef](parser,
dataType)(PartialFunction.empty[JsonToken, AnyRef])
}
/**
* This method skips `FIELD_NAME`s at the beginning, and handles nulls
ahead before trying
* to parse the JSON token using given function `f`. If the `f` failed
to parse and convert the
* token, call `failedConversion` to handle the token.
*/
- private def parseJsonToken(
+ private def parseJsonToken[R >: Null](
--- End diff --
Yes, I said +1 because it explicitly expresses it should be nullable and I
_assumed_ (because I did not check the byte codes by myself and I might be
wrong) that it gives a hint to compiler because `Null` is `null`able (I
remember I googled and played some references for whole several days before
when I was investigating another null-related PR).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
